Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create GHA workflow for altdoc #122

Merged
merged 30 commits into from
Nov 23, 2023
Merged

Create GHA workflow for altdoc #122

merged 30 commits into from
Nov 23, 2023

Conversation

etiennebacher
Copy link
Owner

@etiennebacher etiennebacher commented Nov 22, 2023

Close #66

Very much WIP, just the skeleton for now

TODO:

Copy link

netlify bot commented Nov 22, 2023

Deploy Preview for upbeat-hamilton-47df84 ready!

Name Link
🔨 Latest commit 72a485e
🔍 Latest deploy log https://app.netlify.com/sites/upbeat-hamilton-47df84/deploys/655fbad5e13ff60008b5c8b0
😎 Deploy Preview https://deploy-preview-122--upbeat-hamilton-47df84.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vincentarelbundock
Copy link
Collaborator

This assumes we want to create an all new website every time, with no customization at all?

@vincentarelbundock
Copy link
Collaborator

How about setup_workflow()?

@etiennebacher
Copy link
Owner Author

Quarto installation fails because sudo: command not found. @vincentarelbundock do you think it's because we use a rocker container?

@vincentarelbundock
Copy link
Collaborator

No idea, which is why I use the script linked above ;)

@etiennebacher
Copy link
Owner Author

quarto-dev/quarto-actions#12

There are cases where install-quarto action can't be used (like in docker containers runners).

@etiennebacher
Copy link
Owner Author

The CI went through, need to see how it goes after we merge this. Need to update function name, docs, CI template first

@etiennebacher etiennebacher marked this pull request as ready for review November 23, 2023 20:36
@etiennebacher etiennebacher requested review from vincentarelbundock and removed request for vincentarelbundock November 23, 2023 20:36
@etiennebacher etiennebacher merged commit b12bac6 into main Nov 23, 2023
9 checks passed
@etiennebacher etiennebacher deleted the altdoc-gha branch November 23, 2023 21:13
@vincentarelbundock
Copy link
Collaborator

this is cool

@vincentarelbundock
Copy link
Collaborator

Out of curiosity, what is the benefits of pushing to a separate branch vs. just loading it directly from docs/ in main?

@etiennebacher
Copy link
Owner Author

this is cool

yes but it still doesn't work because git is not installed / badly configured in the container. I'm exploring now

Out of curiosity, what is the benefits of pushing to a separate branch vs. just loading it directly from docs/ in main?

After a you merge a PR / push some commits, you don't need to pull again to import locally the changes in the docs folder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically create a GHA workflow
2 participants