Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static check test #5637

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Static check test #5637

wants to merge 3 commits into from

Conversation

galvana
Copy link
Contributor

@galvana galvana commented Dec 28, 2024

Description Of Changes

Write some things here about the changes and any potential caveats

Code Changes

  • list your code changes here

Steps to Confirm

  1. list any manual steps for reviewers to confirm the changes

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

Copy link

vercel bot commented Dec 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Dec 28, 2024 7:36am

Copy link

cypress bot commented Dec 28, 2024

fides    Run #11635

Run Properties:  status check passed Passed #11635  •  git commit 350d4ac26e ℹ️: Merge 3ab86a1e6fe3a249fabfce83f8378ad97d0a3053 into f77633e33a7b3e77e127caedfbd5...
Project fides
Branch Review refs/pull/5637/merge
Run status status check passed Passed #11635
Run duration 00m 41s
Commit git commit 350d4ac26e ℹ️: Merge 3ab86a1e6fe3a249fabfce83f8378ad97d0a3053 into f77633e33a7b3e77e127caedfbd5...
Committer Adrian Galvan
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Copy link

codecov bot commented Dec 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.14%. Comparing base (f77633e) to head (3ab86a1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5637   +/-   ##
=======================================
  Coverage   87.14%   87.14%           
=======================================
  Files         388      388           
  Lines       24000    24000           
  Branches     2594     2594           
=======================================
  Hits        20914    20914           
  Misses       2525     2525           
  Partials      561      561           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant