Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page Header/Breadcrumb fixes #5626

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Page Header/Breadcrumb fixes #5626

merged 2 commits into from
Dec 19, 2024

Conversation

gilluminate
Copy link
Contributor

Description Of Changes

General clean up fixes after Breadcrumb story migration

Code Changes

  • Remove Layer icon from "All activity" breadcrumb item in D&D
  • Bump paragraph descriptions from sticky PageHeader as needed

Steps to Confirm

  1. Visit Data Detection page and notice that "All activity" does not have an icon next to it
  2. Visit the following pages to make sure page header still looks good:
  • Privacy Notices -> click on a notice
  • Consent reporting
  • Messaging -> click on a message
  • Domains
  • Locations
  • Organization
  • Regulation
  • System config -> click a system -> add /test-datasets to the end of the URL in place of #tabname

Copy link

vercel bot commented Dec 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 7:51pm

Copy link

cypress bot commented Dec 19, 2024

fides    Run #11602

Run Properties:  status check passed Passed #11602  •  git commit fa9a8fa17a ℹ️: Merge 72330eaf08b4f8a148c35931d0b63af3eb824952 into f319894c92b8ec37b5f12661943b...
Project fides
Branch Review refs/pull/5626/merge
Run status status check passed Passed #11602
Run duration 01m 07s
Commit git commit fa9a8fa17a ℹ️: Merge 72330eaf08b4f8a148c35931d0b63af3eb824952 into f319894c92b8ec37b5f12661943b...
Committer Jason Gill
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Copy link
Contributor

@lucanovera lucanovera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested all the pages and they looks good, descriptions are no longer sticking to the top. Approved!

@gilluminate gilluminate merged commit 365ffc5 into main Dec 19, 2024
13 checks passed
@gilluminate gilluminate deleted the gill/breadcrumb-fixes branch December 19, 2024 21:29
Copy link

cypress bot commented Dec 19, 2024

fides    Run #11609

Run Properties:  status check passed Passed #11609  •  git commit 365ffc53bb: Page Header/Breadcrumb fixes (#5626)
Project fides
Branch Review main
Run status status check passed Passed #11609
Run duration 00m 46s
Commit git commit 365ffc53bb: Page Header/Breadcrumb fixes (#5626)
Committer Jason Gill
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants