Action Center results MVP #5622
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gilluminate
commented
Dec 18, 2024
| @@ -32,7 +32,7 @@ export const debounce = (fn: (props?: any) => void, ms = 0) => { | |||
| }; | |||
|
|
|||
| export const formatDate = (value: string | number | Date): string => | |||
| format(new Date(value), "MMMM d, Y, KK:mm:ss z"); | |||
| format(new Date(value), "MMMM d, y, KK:mm:ss z"); | |||
There was a problem hiding this comment.
this update was a breaking change in the new version of date-fns. It does NOT change our existing date formats.
gilluminate
force-pushed
the
gill/HJ-290/action-center-to-show-results
branch
from
39bfa91 to
7ac5686
Compare
fides
|
||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
refs/pull/5622/merge
|
| Run status |
|
| Run duration | 00m 48s |
| Commit |
|
| Committer | Jason Gill |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
4
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
gilluminate
commented
Dec 18, 2024
| @@ -53,7 +53,7 @@ export const useServerSidePagination = () => { | |||
| setPageIndex((prev) => prev + 1); | |||
| }, [setPageIndex]); | |||
| const isNextPageDisabled = useMemo( | |||
| () => pageIndex === totalPages, | |||
| () => !!totalPages && (pageIndex === totalPages || totalPages < 2), | |||
There was a problem hiding this comment.
We should disable the "Next" button if there's only 1 page or if there was an error (0 pages).
|
|
||
| return ( | ||
| <List.Item data-testid={`monitor-result-${key}`} {...props}> | ||
| <Skeleton avatar title={false} loading={showSkeleton} active> |
There was a problem hiding this comment.
This is how Ant's own examples utilize skeletons during loading state. Pretty cool that it just wraps the content!
|
|
||
| import { MonitorSummaryPaginatedResponse } from "./types"; | ||
|
|
||
| const actionCenterApi = baseApi.injectEndpoints({ |
There was a problem hiding this comment.
I opted to create a dedicated slice for this instead of building on the D&D slice. I may decide to change that depending how big this gets.
revert Back Button enhancement in favor of Breadcrumbs migration
Update action-center.cy.ts
gilluminate
force-pushed
the
gill/HJ-290/action-center-to-show-results
branch
from
fd7dc1d to
8f6b8a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes HJ-290, HJ-334
Description Of Changes
As a user, I want to view the results of my website monitors in a list view that is by default grouped by monitor run, so that I can triage the results and make updates as needed to my system and data inventory.
Code Changes
Related maintenance:
date-fnsFeature work:
Steps to Confirm locally
fidesplusrepo (asachs/HJ-295).turbo devfrom theclientsdirectoryPre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works