Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release 2.52.0 #5621

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

release 2.52.0 #5621

wants to merge 7 commits into from

Conversation

Roger-Ethyca
Copy link
Contributor

Pre-Release Steps

General

From the release branch, confirm the following:

  • Quickstart works: nox -s quickstart (verify you can complete the interactive prompts from the command-line)
  • Test environment works: nox -s "fides_env(test)" (verify the admin UI on localhost:8080, privacy center on localhost:3001, CLI and webserver)
  • Have Roger run a QATouch automation run

Next, run the following checks via the test environment:

API

CLI

Run these from within the test environment shell:

  • git reset --hard - Note: This is required for the pull command to work
  • fides user login
  • fides push src/fides/data/sample_project/sample_resources/
  • fides pull src/fides/data/sample_project/sample_resources/
  • fides evaluate src/fides/data/sample_project/sample_resources/
  • fides generate dataset db --credentials-id app_postgres test.yml - Note: Because the filesystem isn't mounted, the new file will only show up within the container
  • fides scan dataset db --credentials-id app_postgres

Privacy Center

  • Every navigation button works
  • DSR submission succeeds
  • Consent request submission succeeds

Admin UI

  • Every navigation button works
  • DSR approval succeeds
  • DSR execution succeeds

User Permissions

  • Verify user creation
  • Verify a Viewer can view all systems
  • Verify a Data Steward can edit systems they are assigned

Documentation

  • Verify that the CHANGELOG is formatted correctly and clean up verbiage where needed
  • Verify that the CHANGELOG is representative of the actual changes

⚠️ Note that any updates that need to be made to the CHANGELOG should not be commited directly to the release branch.
Instead, they should be committed on a branch off of main and then PR'd and merged into main, before being cherry-picked
over to the release branch. This ensures that the CHANGELOG stays consistent between the release branch and main.

Publishing the release

When publishing the release, be sure to include the following sections in the release description:

  • ## Release Pull Request section that includes a link back to the release PR (i.e., this one!) for tracking purposes
  • ## QA Touch Test Run section that includes a link to the QATouch test run (QA team should provide this)

Post-Release Steps

Copy link

vercel bot commented Dec 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 5:56pm

Copy link

cypress bot commented Dec 18, 2024

fides    Run #11622

Run Properties:  status check passed Passed #11622  •  git commit 86f60a7a31: Fix creation of new root level labels (#5630)
Project fides
Branch Review release-2.52.0
Run status status check passed Passed #11622
Run duration 00m 46s
Commit git commit 86f60a7a31: Fix creation of new root level labels (#5630)
Committer Lucano Vera
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 73.77049% with 16 lines in your changes missing coverage. Please review.

Project coverage is 87.13%. Comparing base (12bc0f9) to head (86f60a7).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...rc/fides/api/api/v1/endpoints/generic_overrides.py 65.21% 13 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5621      +/-   ##
==========================================
- Coverage   87.16%   87.13%   -0.04%     
==========================================
  Files         388      388              
  Lines       23940    23988      +48     
  Branches     2586     2594       +8     
==========================================
+ Hits        20868    20902      +34     
- Misses       2514     2525      +11     
- Partials      558      561       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Dec 19, 2024

fides    Run #11623

Run Properties:  status check passed Passed #11623  •  git commit 883c1af86b ℹ️: Merge 86f60a7a3175df63797169921f01dc8b938d0499 into cf0e0f514ea62f47da121301f369...
Project fides
Branch Review refs/pull/5621/merge
Run status status check passed Passed #11623
Run duration 01m 24s
Commit git commit 883c1af86b ℹ️: Merge 86f60a7a3175df63797169921f01dc8b938d0499 into cf0e0f514ea62f47da121301f369...
Committer Roger Plotz
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants