-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LA-108: Expand on BQ Enterprise test coverage- partitioning, custom identities #5618
Open
eastandwestwind
wants to merge
6
commits into
main
Choose a base branch
from
LA-108
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
eastandwestwind
force-pushed
the
LA-108
branch
from
December 18, 2024 16:24
1acaa54
to
4143e08
Compare
fides Run #11562
Run Properties:
|
Project |
fides
|
Branch Review |
refs/pull/5618/merge
|
Run status |
Passed #11562
|
Run duration | 00m 50s |
Commit |
221bd46b19 ℹ️: Merge 4143e088b9cd9d96ec95306bdbb29bdd658c85b9 into ebbd5d8851b5965b8fa28e52ccdb...
|
Committer | Catherine Smith |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
4
|
Upgrade your plan to view test results. | |
View all changes introduced in this branch ↗︎ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5618 +/- ##
=======================================
Coverage 87.17% 87.17%
=======================================
Files 388 388
Lines 23931 23931
Branches 2586 2586
=======================================
Hits 20861 20861
Misses 2512 2512
Partials 558 558 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://ethyca.atlassian.net/browse/LA-108
Description Of Changes
This PR covers additional test cases for partitioning, multiple identities, custom identities:
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md
updatedmain
downgrade()
migration is correct and works