Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LA-108: Expand on BQ Enterprise test coverage- partitioning, custom identities #5618

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

eastandwestwind
Copy link
Contributor

@eastandwestwind eastandwestwind commented Dec 18, 2024

Closes https://ethyca.atlassian.net/browse/LA-108

Description Of Changes

This PR covers additional test cases for partitioning, multiple identities, custom identities:
Screenshot 2024-12-18 at 5 18 34 PM

Code Changes

  • Adds tests
  • updates Wiki on how to re-populate BQ enterprise tables if they are erased

Steps to Confirm

  1. Confirm all tests pass

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

Copy link

vercel bot commented Dec 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Dec 18, 2024 4:25pm

Copy link

cypress bot commented Dec 18, 2024

fides    Run #11562

Run Properties:  status check passed Passed #11562  •  git commit 221bd46b19 ℹ️: Merge 4143e088b9cd9d96ec95306bdbb29bdd658c85b9 into ebbd5d8851b5965b8fa28e52ccdb...
Project fides
Branch Review refs/pull/5618/merge
Run status status check passed Passed #11562
Run duration 00m 50s
Commit git commit 221bd46b19 ℹ️: Merge 4143e088b9cd9d96ec95306bdbb29bdd658c85b9 into ebbd5d8851b5965b8fa28e52ccdb...
Committer Catherine Smith
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.17%. Comparing base (ebbd5d8) to head (7a5b542).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5618   +/-   ##
=======================================
  Coverage   87.17%   87.17%           
=======================================
  Files         388      388           
  Lines       23931    23931           
  Branches     2586     2586           
=======================================
  Hits        20861    20861           
  Misses       2512     2512           
  Partials      558      558           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant