Migrate Breadcrumbs to Ant #5610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gilluminate
force-pushed
the
gill/HJ-213/migrate-breadcrumbs-to-ant
branch
from
dd1c5c0 to
46561cd
Compare
fides
|
||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
refs/pull/5610/merge
|
| Run status |
|
| Run duration | 00m 49s |
| Commit |
|
| Committer | Jason Gill |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
4
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
gilluminate
force-pushed
the
gill/HJ-213/migrate-breadcrumbs-to-ant
branch
from
46561cd to
3dfdb4e
Compare
gilluminate
force-pushed
the
gill/HJ-213/migrate-breadcrumbs-to-ant
branch
from
dd8d8a8 to
fac1944
Compare
lucanovera
requested changes
Dec 18, 2024
There was a problem hiding this comment.
Great work here. The breadcrums looks great and you took the oportunity to refactor and simplify a lot of repetead code.
I left some questions and code improvement suggestions. My main issues are the deleted page and the tricky bug for the sticky page header.
clients/admin-ui/src/features/user-management/UserManagementLayout.tsx
Outdated
Show resolved
Hide resolved
clients/admin-ui/src/pages/systems/configure/[id]/test-datasets.tsx
Outdated
Show resolved
Hide resolved
clients/admin-ui/src/features/data-discovery-and-detection/DiscoveryMonitorBreadcrumbs.tsx
Show resolved
Hide resolved
lucanovera
approved these changes
Dec 18, 2024
fides
|
||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 00m 51s |
| Commit |
|
| Committer | Jason Gill |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
0
|
|
Flaky
|
0
|
|
Pending
|
0
|
|
Skipped
|
0
|
|
Passing
|
4
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes HJ-213
Description Of Changes
Migrate Chakra breadcrumbs to Ant Design breadcrumbs. Update PageHeader component to make use of proper Heading as well as built-in breadcrumb support. Back button has been replaced by breadcrumbs for new pattern and consistency.
Code Changes
NextBreadcrumbcomponent that supports NextJS navigation in Ant BreadcrumbsPageHeadercomponent to use proper H1 heading (still Chakra for now)PageHeaderPageHeaderto all pages for consistencyLayoutandFixedLayoutfor consistencyDiscoveryMonitorBreadcrumbsto use newNextBreadcrumband Carbon iconsDatasetBreadcrumbs.tsxwhich is now obsoleteSteps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works