Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove engine reuse #5547

Open
wants to merge 5 commits into
base: release-2.50.0
Choose a base branch
from
Open

Remove engine reuse #5547

wants to merge 5 commits into from

Conversation

galvana
Copy link
Contributor

@galvana galvana commented Nov 27, 2024 •
edited by jira bot
Loading

Closes LA-180

Description Of Changes

Code Changes

  • Updating DatabaseTask.get_new_session to use a new Engine when creating a new Session

Steps to Confirm

  1. Tests should pass

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel Vercel
Copy link

vercel bot commented Nov 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Dec 17, 2024 8:30pm

@galvana galvana requested a review from tvandort November 27, 2024 18:57
@galvana galvana changed the base branch from main to release-2.50.0 November 27, 2024 19:00
@galvana galvana marked this pull request as ready for review November 27, 2024 19:00
@cypress Cypress
Copy link

cypress bot commented Nov 27, 2024 •
edited
Loading

fides    Run #11543

Run Properties:  status check passed Passed #11543  •  git commit a01df67bbb ℹ️: Merge 00dff8fd0f025e4a992f2d84925e0081764b7a62 into 6cb3bc2b32021a12d843509bfc0d...
Project fides
Branch Review refs/pull/5547/merge
Run status status check passed Passed #11543
Run duration 00m 39s
Commit git commit a01df67bbb ℹ️: Merge 00dff8fd0f025e4a992f2d84925e0081764b7a62 into 6cb3bc2b32021a12d843509bfc0d...
Committer Adrian Galvan
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvandort tvandort Awaiting requested review from tvandort

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@galvana @Vagoasdf