add blob da fee to NewL1CostFuncFjord
#18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiqiangxu
force-pushed
the
mod_l1cost
branch
from
fe9afc3 to
f74cea1
Compare
zhiqiangxu
force-pushed
the
mod_l1cost
branch
from
f74cea1 to
491e2ae
Compare
|
This is for Fjord, how about Holocene? Or they will use the same function? |
Yeah the same function, there's no change regarding L1 cost in Holocene. |
qizhou
approved these changes
Nov 4, 2024
dajuguan
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we only add blob da fee to
newL1CostFuncEcotone, this PR does the same forNewL1CostFuncFjord, which will be used if we activate Holocene HF.