WIP: ECIP1045 Features #671

whilei · 2018-09-17T10:12:40Z

This branch is a work in progress. While most features (except EIP1283) have been implemented, still TODO is testing and review, including:

integration tests with documented contracts using OPCODES/pcontracts in question
code review and implementation comparison with Parity and SVM machines
regression test(s)
import @mersinvald 's handrolled JSON Byz+Const tests from SVM
refactor (places like exec2 are just plain ugly)
reconcile branch ecip1045-with-tests, which replaces /tests/ with ethereum/tests; this depends heavily on establishing correctness of those tests for ETC, fixing test generators/fillers

…code

solution: since STATICCALL functions equivalently to CALL, use congruent behavior to CALL during gas decision log switch statement

…be like DELEGATECALL https://github.com/ethereum/go-ethereum/blob/76069eef38082089d2eaf99661a80e1a953bf271/core/vm/memory_table.go solution: change switch case condition

Includes a fix where signature had accepted 'value' param, and should not have

This should disallow state modificaation on StaticCall method, and if an opcode is called that writes to the state layer, the vm should throw an exception solution: - implement IsReadOnly and SetReadOnly interface methods - add field for opcode instruction regard whether or not it makes (or can make) changes to state, eg LOG*, SSTORE, SUICIDE, and possibly CALL returning a non-zero value.

solution: add placehold fn to satisfy interface

... it will cause confusion solution: rename fork to ECIP1045

solution: this is handled in core/vm/vm.go conditional, see comment there

solution: include congruent DELEGATECALL:STATICCALL tests

…face (missing IsECIP1045 method) solution: implement method as default

solution: implement IsECIP1045, IsReadOnly, and SetReadOnly methods for associated RuleSet and VMEnv structs

…nterface methods solution: implement them

solution: set in fn Since STATICCALL and incoming OPCODES should only be activated after the fork (and tests configured with envs after the fork), this number can be safely set to 0

solution: remove typo

solution: fix stack signature

solution: refactor field to vm.Opcode#IsStateModifying

…interface solution: remove it core.ChainConfig#IsEIP658 can still be used for implementation

- allows reuse of init_code keccak hash - modifies Create2 unit tests for consistency with ETH

It is implemented in crypto/

- moves spec tests (again) from crypto -> core/vm/ because this allows gas testing as well as expected address hash val tests.

If PostState is present in RLP decoded Receipt (received from network), we can't assume anything about transaction Status, so it should be set to TxStatusUnknown.

Type of Status changed to from `byte` to `uint8` to emphasize that it's a scalar. Struct used in RLP encoding changed, so it can handle both `uint8` (Status) and `[]byte` (PostState). RLP decoding changed accordingly. Comment added.

solution: append 'Msg' to name to make clear why string and not error type

solution: fix typo

This causes TestEIP658RLPRoundTrip2 to break.

solution: invalid returning of writer.Flush() causes EOF error

Ensures round trip RLP en/de-coder works for both empty (eg zero-value address) hash and arbitrary value.

whilei added 30 commits August 20, 2018 10:27

begin work on implementing STATICCALL from scratch

4126cd8

Implement STATICCALL opcodes in vm/opcodes dictionaries

e5a31fd

Implement IsByzantium ruleset interface fn for use with STATICCALL op…

2b7e2e8

…code

Placeholder for opStaticCall as vm instruction

e8ff0a4

💾

1546640

problem: must calculate gas and size for STATICCALL

77e0db2

solution: since STATICCALL functions equivalently to CALL, use congruent behavior to CALL during gas decision log switch statement

problem: (rel prev commit) STATICCALL gas and mem calculation should …

0bcabc7

…be like DELEGATECALL https://github.com/ethereum/go-ethereum/blob/76069eef38082089d2eaf99661a80e1a953bf271/core/vm/memory_table.go solution: change switch case condition

Implement StaticCall interface methods and fns

006aa1b

Includes a fix where signature had accepted 'value' param, and should not have

problem: ChainConfig must implement RuleSet IsByzantium method

3dbe01c

solution: add placehold fn to satisfy interface

vm/instructions: opStaticCall implemented

26409fd

core/vm/gas: implement STATICCALL gas lookup

9aa304b

problem: IsByzantium should not use name 'Byzantium'

d8b8f91

... it will cause confusion solution: rename fork to ECIP1045

problem: CREATE modifies state; should be designated as writer

f03c6e4

core,core/vm: implement errWriteProtection for state-modifying vm cases

71219e7

core/vm: include RuleSet.IsECIP1045 conditional for evm.Env

f8c40be

problem: CALL only causes state mod if value transfer

90b8313

solution: this is handled in core/vm/vm.go conditional, see comment there

problem: core/vm/jump_table_test fails

ef23dd4

solution: include congruent DELEGATECALL:STATICCALL tests

problem: core/vm/runtime: ruleSet does not implement vm.RuleSet inter…

cf2352c

…face (missing IsECIP1045 method) solution: implement method as default

problem: cmd/evm: mock EVMs don't implement required interface methods

a4e38b2

solution: implement IsECIP1045, IsReadOnly, and SetReadOnly methods for associated RuleSet and VMEnv structs

problem: tests/: Env and RuleSet mock doesn't implement required VM i…

f85ec47

…nterface methods solution: implement them

problem: tests/: panic caused by unset RuleSet ECIP1045Block val

0ef11b8

solution: set in fn Since STATICCALL and incoming OPCODES should only be activated after the fork (and tests configured with envs after the fork), this number can be safely set to 0

problem: execStaticCall using AsDelegate method for Contract

2edd509

solution: remove typo

problem: stack-> causes panic because args count mismatch

d00e6b7

solution: fix stack signature

core/execution: minor comment improvement

4e70678

problem: LOG0 should be be 'writes: true'

7d7e145

problem: additional 'writes' field can be refactored to predicate fn

bf96b82

solution: refactor field to vm.Opcode#IsStateModifying

Implement RETURNDATASIZE and RETURNDATACOPY

9f48f45

Implement RETURNDATASIZE and RETURNDATACOPY

479f531

REVERT: opcodes and gas

8600aa9

whilei and others added 29 commits October 11, 2018 11:55

problem@core: EIP658 not related to EVM, can be removed from ruleset …

5a840bc

…interface solution: remove it core.ChainConfig#IsEIP658 can still be used for implementation

Merge branch 'ecip1045-CREATE2tests' into ecip1045-dev

6e575e5

Merge branch 'fix/bn256_go1.11' into ecip1045

ed98f76

core/crypto: unit test Keccak256Hash (sanity check)

f7cc1bd

core/vm: Create2 unit tests

8ee6e3c

core,crypto: change CreateAddress2 signature,

b1dd499

- allows reuse of init_code keccak hash - modifies Create2 unit tests for consistency with ETH

core/vm: remove Create2 test from this package

0eb3fa0

It is implemented in crypto/

core/vm: SHA3 word cost for CREATE2

4e256f7

core,crypto: implement and test SHA3/word cost for CREATE2

6c85ab8

- moves spec tests (again) from crypto -> core/vm/ because this allows gas testing as well as expected address hash val tests.

tests: Include EIP1014 document

866b7ef

Merge remote-tracking branch 'upstream/ecip1045' into ecip1045

3f63e5b

EIP-658 - processing of PostState and Status

97a0425

Use of new function to check is EIP-658 configured

c85faf1

Improved error handling

9a9c577

Comment finished

333c5bd

Receipt RLP encoding/decoding - defensive approach

e649515

Proper Status in RLP deserialization

7f6df5a

If PostState is present in RLP decoded Receipt (received from network), we can't assume anything about transaction Status, so it should be set to TxStatusUnknown.

Fix Receipt creation in old tests

c66f27d

Replace hand-coded equality test with bytes.Equal

dbab490

Invalid Receipt decoding tests

780cd16

Proper encoding/decoding of Receipt's Status field

501d3cb

Type of Status changed to from `byte` to `uint8` to emphasize that it's a scalar. Struct used in RLP encoding changed, so it can handle both `uint8` (Status) and `[]byte` (PostState). RLP decoding changed accordingly. Comment added.

Receipt RLP decoding: refactoring, new test case

b5b63e5

Fix of error message

51892f8

Error formats refactored

e422fba

problem: expectedError isn't really an error

7e6a0a7

solution: append 'Msg' to name to make clear why string and not error type

problem: testing sub-run should call tt Testing, not t

7a6e8dc

solution: fix typo

core/types: handle unhandled errors in receipt_test

b33545a

This causes TestEIP658RLPRoundTrip2 to break.

problem: encode/decode failing during RT test

fd96f5f

solution: invalid returning of writer.Flush() causes EOF error

problem: should test empty hash bytes and arbitrary bytes as root

88d65ac

Ensures round trip RLP en/de-coder works for both empty (eg zero-value address) hash and arbitrary value.

soc1c closed this Jun 14, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP: ECIP1045 Features #671

WIP: ECIP1045 Features #671

whilei commented Sep 17, 2018 •

edited

Loading

WIP: ECIP1045 Features #671

WIP: ECIP1045 Features #671

Conversation

whilei commented Sep 17, 2018 • edited Loading

whilei commented Sep 17, 2018 •

edited

Loading