Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

std lib v2 #986

Draft
wants to merge 7 commits into
base: fe-v2
Choose a base branch
from
Draft

std lib v2 #986

wants to merge 7 commits into from

Conversation

g-r-a-n-t
Copy link
Member

@g-r-a-n-t g-r-a-n-t commented Feb 20, 2024 •
edited
Loading

No description provided.

@g-r-a-n-t g-r-a-n-t marked this pull request as draft February 20, 2024 00:48
@g-r-a-n-t g-r-a-n-t force-pushed the library2 branch 3 times, most recently from d9589bd to 6308665 Compare May 1, 2024 21:43
@g-r-a-n-t g-r-a-n-t force-pushed the library2 branch 2 times, most recently from f0dfd80 to 70faf08 Compare May 14, 2024 04:19
@g-r-a-n-t g-r-a-n-t changed the title library2 std lib v2 with basic operations May 14, 2024
g-r-a-n-t
g-r-a-n-t commented May 14, 2024
View reviewed changes
crates/driver2/src/lib.rs Outdated Show resolved Hide resolved
crates/library2/std/src/num/int/extend.fe Outdated Show resolved Hide resolved
crates/library2/std/src/num/int/ops/arith.fe Outdated Show resolved Hide resolved
crates/library2/std/src/ops/arith.fe Outdated Show resolved Hide resolved
@g-r-a-n-t g-r-a-n-t force-pushed the library2 branch 3 times, most recently from 9b7694c to 3c32fdf Compare May 16, 2024 15:51
@g-r-a-n-t g-r-a-n-t marked this pull request as ready for review May 16, 2024 15:53
@Y-Nak
Copy link
Member

Y-Nak commented May 17, 2024 •
edited
Loading

I think it'd be better to have a call on this PR to align with.
Things that I'd like to talk about are

  • definitions of the traits in ops::cmp and ops::logical, and Plus trait.
  • abort definition and its usage
  • std module structure
  • driver's setting

@g-r-a-n-t g-r-a-n-t changed the title std lib v2 with basic operations std lib v2 Jun 4, 2024
@g-r-a-n-t g-r-a-n-t force-pushed the library2 branch 2 times, most recently from 8bd77f2 to f4baa26 Compare June 18, 2024 15:45
@g-r-a-n-t g-r-a-n-t marked this pull request as draft June 21, 2024 15:48
@g-r-a-n-t g-r-a-n-t force-pushed the library2 branch 4 times, most recently from 9a66a35 to 38df535 Compare June 25, 2024 17:01
Grant Wuerker added 2 commits July 8, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@g-r-a-n-t @Y-Nak