fix(eof): eofwrap.py to ignore invalid blocks

[pdobacz]

🗒️ Description

There is no support for invalid FixtureTransactions to be read from JSON, so we cannot include invalid blocks easily. However as this is not central to the behavior eofwrap tests are intended to test, we can just skip these invalid blocks with the same end effect on the test.

Unfortunately, the fix isn't limited to that. It seems like the fix to requests serialization/hashing (#990) missed a detail when the requests_lists is used to construct requests (like from t8n output). Please double check carefully if this fix is fine.

Note also that for devnet-5 this would be partially hidden by the fact, that we don't include empty requests in the commitment anymore, meaning that all empty requests will not trigger the problem

🔗 Related Issues

NA

✅ Checklist

• All: Set appropriate labels for the changes.
• All: Considered squashing commits to improve commit history.
• All: Added an entry to CHANGELOG.md.
• All: Considered updating the online docs in the ./docs/ directory.
• Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
• Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
• Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
• Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

[pdobacz]

It seems the request hash problem affects filling state_tests with evmone too, presumably with other t8n's too?

[chfast]

This fixes filling of EOF tests for me.

[marioevz]

One comment that is a breaking issue, there must be some other approach to this.

[marioevz]

This breaks EIP-7685 tests, because of this change in the spec: ethereum/EIPs@5ac0297

I think the requests lists from the blocks that are being parsed and passed to this function might be outdated, so the source might need to be fixed first.

[pdobacz]

Ha, I thought this change isn't yet implemented. My change is only about parity between the two ifs in this function here, but still in prague-devnet-4 world.

[pdobacz]

ok, hold on, I think there indeed is another solution - never pass b'' elements in the requests_lists, and then it works as prague-devnet-5. I think I was wrong about that particular piece, some debugging gone wrong on my part.

I can propose an alternative fix in a second

[pdobacz]

OK, take a look now pls. I still ended up adjusting this function instead of source (I tried that too, but then it is problematic to work out the type of the request lists entry).

I might still be deeply confused here, I was certain I knew what was going on, but not anymore 😅.