-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add EIP-7702 transactions and receipts #575
base: main
Are you sure you want to change the base?
Conversation
Please also add the 7702 tx to |
https://github.com/ethereum/EIPs/blob/master/EIPS/eip-7702.md The issue originally said 1559 + auth list, but EIP spec now says 4844 instead. "of the outer transaction follow the same semantics as EIP-4844." |
@lightclient can you review this plz hope I fixed your concern |
I think i messed up the branch with a bad rebase |
Plz move the conversation to #592 |
Please fix the branch here instead of opening a separate PR. It's important to keep the conversation around the change in the same thread. |
@lightclient resolved the issue thnks for the feedback and srry for skipping the issue and opening the new one |
de1ffbc
to
030f607
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At Nethermind we just merged support for 7702 (NethermindEth/nethermind#7459) and we're currently extending our test suite. I have a couple of questions regarding this spec update and I would appreciate if you could take a look at them
52439ef
to
b45ec2e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks complete to me
@lightclient on mekong there's currently v and yParity for this value, the EIP defines this as yParity, even though values >1 can technically be included in a (failing) transaction.
so imo naming this yParity, consistent with the EIP, makes the most sense
Co-authored-by: Lautaro Emanuel <[email protected]>
0f0de96
to
46762e5
Compare
Removed tests for now. I will add them back in #612 |
Motivation
This is for closing #561
As mentioned I have added same eip 1559 + auth list referenced to reciept schema where added authlist definition