Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add
eth_simulateV1
#484base: main
Are you sure you want to change the base?
add
eth_simulateV1
#484Changes from 35 commits
31fcbe5
8b020ce
aaab3f8
8ab6539
61fb231
45313dd
d9411e0
06d27bd
b4ce098
0043e12
3095c08
c7ec336
c20052c
7aee5b3
8996847
e76cb57
dde3124
db721c4
aef37eb
85ad1a4
21c6dfa
e27cf9a
b597a7f
1ccfd37
f297b4f
e3332ea
e913466
8141886
2ee9fc2
42d1249
55f657c
0256a4b
de3e3f5
d7b4616
3324ce9
e56d320
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: do we throw here on post-merge blocks if the uncles are non-empty? There can be no uncles post-merge and the uncle hash is therefore also stubbed to the empty trie hash.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are ETH logs? For clarity it would be nice to link that these are explain further down 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
size
is not part of the block header (so I also don't see why it is necessary here?)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we throw for the fields set if these are not available for the tx type? (The 4 types below here, so
maxPriorityFeePerGas
,maxFeePerGas
,accessList
,blobVersionedHashes
)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(they can be set and it is fine, but might be confusing for the end user)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blob txs cannot be simulated it seems per the current spec since it cannot be overridden.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if I have a specific use case that I want a block hash of a previous block be of some kind? Then I should be able to override
hash
as well.What about
withdrawals
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also argue that there is a max number, because if one allows to create only one block, then one can still request block very high number and this would impose a lot of phantom block hashings.