Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-7702: Make EXTCODE* return sentinel values for delegated accounts [devnet-5 spec update] #1072

Open
wants to merge 2 commits into
base: eip-7702
Choose a base branch
from

Conversation

gumb0
Copy link
Member

@gumb0 gumb0 commented Nov 21, 2024

Based on #961

@gumb0 gumb0 self-assigned this Nov 21, 2024
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 97.82609% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.45%. Comparing base (681d562) to head (14d523b).

Files with missing lines Patch % Lines
lib/evmone/instructions_calls.cpp 90.90% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           eip-7702    #1072      +/-   ##
============================================
- Coverage     94.33%   93.45%   -0.89%     
============================================
  Files           158      158              
  Lines         17448    17451       +3     
============================================
- Hits          16460    16309     -151     
- Misses          988     1142     +154     
Flag Coverage Δ
eof_execution_spec_tests 23.23% <39.13%> (-0.07%) ⬇️
ethereum_tests 26.07% <26.08%> (-0.05%) ⬇️
ethereum_tests_silkpre 18.82% <25.00%> (-0.03%) ⬇️
execution_spec_tests ?
unittests 89.46% <97.82%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
lib/evmone/instructions.hpp 100.00% <100.00%> (+0.60%) ⬆️
test/state/host.cpp 100.00% <100.00%> (ø)
test/state/host.hpp 100.00% <ø> (ø)
test/state/state.cpp 94.35% <ø> (-4.66%) ⬇️
test/state/state.hpp 100.00% <100.00%> (ø)
test/unittests/state_transition_eip7702_test.cpp 100.00% <100.00%> (ø)
lib/evmone/instructions_calls.cpp 97.90% <90.90%> (-0.34%) ⬇️

... and 7 files with indirect coverage changes

@gumb0 gumb0 force-pushed the eip-7702-extcode branch 4 times, most recently from 1e3ce30 to 5d28c65 Compare November 22, 2024 14:52
@gumb0 gumb0 force-pushed the eip-7702 branch 2 times, most recently from 15c5ce5 to dcdb8c8 Compare November 25, 2024 12:00
@gumb0 gumb0 force-pushed the eip-7702-extcode branch 3 times, most recently from 452340a to a40c1a2 Compare November 27, 2024 10:35
@gumb0 gumb0 marked this pull request as ready for review November 27, 2024 12:01
gumb0 added 2 commits December 5, 2024 14:02
For EXTCODE* instructions do not follow delegation, but return sentinel values instead.
@gumb0 gumb0 changed the title EIP-7702: Make EXTCODE* return sentinel values for delegated accounts EIP-7702: Make EXTCODE* return sentinel values for delegated accounts [devnet-5 spec update] Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant