Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add a state test reaching CALL max depth #1007

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chfast
Copy link
Member

@chfast chfast commented Sep 13, 2024

No description provided.

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.90%. Comparing base (1004496) to head (69b3c35).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1007   +/-   ##
=======================================
  Coverage   93.89%   93.90%           
=======================================
  Files         147      147           
  Lines       15507    15519   +12     
=======================================
+ Hits        14561    14573   +12     
  Misses        946      946           
Flag Coverage Δ
eof_execution_spec_tests 17.48% <0.00%> (-0.02%) ⬇️
ethereum_tests 27.70% <0.00%> (-0.03%) ⬇️
ethereum_tests_silkpre 19.41% <0.00%> (-0.02%) ⬇️
execution_spec_tests 18.98% <0.00%> (-0.02%) ⬇️
unittests 89.01% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
test/unittests/state_transition.cpp 97.58% <100.00%> (ø)
test/unittests/state_transition_call_test.cpp 100.00% <100.00%> (ø)

@pdobacz
Copy link
Collaborator

pdobacz commented Sep 13, 2024

There's such test in EEST already https://github.com/ethereum/execution-spec-tests/blob/main/tests/prague/eip7692_eof_v1/eip7069_extcall/test_calls.py#L874 (judging by name only, I didn't read the diff)

@chfast
Copy link
Member Author

chfast commented Sep 13, 2024

Yes, I just need one example locally.

It actually crashes because of the stack overflow. This is because we don't run EEST with Clang nor MSVC debug builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants