Add additional pre-checks to the DisputeGameUpgade
#431
+71
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastianst
force-pushed
the
seb/more-fp-verification
branch
from
4ad9f84 to
f19ee2e
Compare
mbaxter
reviewed
Dec 20, 2024
sebastianst
force-pushed
the
seb/sep-025-fp-fix
branch
from
98b9fa0 to
28e82b3
Compare
sebastianst
force-pushed
the
seb/more-fp-verification
branch
from
33efcb6 to
cc7e71a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds additional pre-checks to the
DisputeGameUpgade, in particular comparing the existing and new games' configuration for parity (or differences, where expected).Stacked on top of #421 but otherwise good to merge.
Additional context
Taken mostly from #410