Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simulate non-terminal tasks in CI - @bordolot contribution #420

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

blmalone
Copy link
Contributor

@blmalone blmalone commented Dec 17, 2024

We have a draft PR that was a good first shot at adding the simulation of non-terminal tasks to CI here.

This PR builds upon that branch, preserving the open source contributors (@bordolot) commits.

Closes: #337

@blmalone blmalone requested review from a team as code owners December 17, 2024 19:35
@blmalone blmalone requested a review from maurelian December 17, 2024 19:35
@blmalone blmalone marked this pull request as draft December 17, 2024 19:35
@blmalone blmalone removed the request for review from maurelian December 17, 2024 19:46
@blmalone blmalone marked this pull request as ready for review December 19, 2024 01:08
@blmalone blmalone requested review from mds1 and Ethnical December 19, 2024 01:09
@blmalone
Copy link
Contributor Author

@bordolot Hey! Thanks for making the contribution. I've made a few commits on top of yours to get this over the line. We really value you chipping in here. Feel free to review/suggest edits. I'm going to ask @mds1 for a review and hopefully we can get this merged soon.

@blmalone blmalone changed the title Simulate non-terminal tasks in CI Simulate non-terminal tasks in CI - @bordolot contribution Dec 19, 2024
@bordolot
Copy link

I’m glad to hear that! This is my first-ever contribution to any project, and I’m very excited to see it progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically run tasks in CI if task is in a non-terminal state
2 participants