feat: rename superchain-configuration to superchain-config #483
+14
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maurelian
requested review from
protolambda,
tynes,
ajsutton,
sebastianst and
mslipper
as code owners
tynes
reviewed
Dec 23, 2024
| @@ -142,12 +143,12 @@ graph LR | |||
|
|
|||
| #### Notes for Core L1 Smart Contracts | |||
|
|
|||
| - The `Batch Inbox Address` described above (**highlighted in GREY**) is *not* a smart contract and is instead an arbitrarily | |||
| - The `Batch Inbox Address` described above (**highlighted in GREY**) is _not_ a smart contract and is instead an arbitrarily | |||
There was a problem hiding this comment.
Just noting this, when OPCM launches then it is no longer an arbitrarily selected account, it has a definition
tynes
approved these changes
Dec 23, 2024
|
Good to merge once CI linting job is fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A more intuitive filename for the SuperchainConfig contract spec.