feat: Proofs: DelayedWETH Incident response improvements #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wildmolasses
requested review from
ajsutton,
clabby,
Inphi,
refcell and
mbaxter
as code owners
ajsutton
reviewed
Nov 19, 2024
There was a problem hiding this comment.
Will leave final approval to @smartcontracts but generally looks good to me. I'm personally ok with updating this in place since no-one needs to implement the old contract behaviour.
| when `delayedWethPaused` is `true`, unless the caller is the `owner()`. | ||
| - `DelayedWETH` has a `setDelayedWethPaused(bool)` function that allows the `owner()` address to either pause or unpause | ||
| withdrawals and transfers. | ||
| - `DelayedWETH` has a `hold()` function that allows the `owner()` address to, for any holder, give itself an allowance and |
There was a problem hiding this comment.
We should include the arguments for hold here for consistency. I also wonder if there's a better name than hold given it takes the funds, not just holding them. Maybe reallocate? Not sure how much it's worth worrying about this.
There was a problem hiding this comment.
Probably wouldn't bother worrying about it
There was a problem hiding this comment.
Agree on the arguments
| - `DelayedWETH` has a `hold()` function that allows the `owner()` address to give itself an allowance from any address. | ||
| `withdraw(guy,wad)` will not be callable when `SuperchainConfig.paused()` is `true`. Also, `withdraw(guy,wad)` is not callable | ||
| when `delayedWethPaused` is `true`, unless the caller is the `owner()`. | ||
| - `DelayedWETH` has a `setDelayedWethPaused(bool)` function that allows the `owner()` address to either pause or unpause |
There was a problem hiding this comment.
Delayed weth pause should be settable by the guardian instead of the owner
wildmolasses
force-pushed
the
proofs-iri-DelayedWETH
branch
from
b9b1569 to
ce0e3e1
Compare
wildmolasses
force-pushed
the
proofs-iri-DelayedWETH
branch
from
ce0e3e1 to
7053978
Compare
wildmolasses
force-pushed
the
proofs-iri-DelayedWETH
branch
from
7053978 to
be4ab6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: ethereum-optimism/optimism#12172 > ethereum-optimism/optimism#12174
This spec PR modifies the existing DelayedWETH spec to support the design changes outlined in Design Docs: DelayedWETH expansion
Let me know what you think of my decision to modify the DelayedWETH spec in place, rather than break it out into its own md file.
Also, if you have a suggestion on how to represent upgradeability concerns (i.e. I took care on storage slots here; should it be documented here or in FMA?) please let me know.