Isthmus: L2 Withdrawals root spec updates #396
Conversation
vdamle
force-pushed
the
vd/h-l2-withdrawals-root
branch
from
8d6e224 to
eab4f18
Compare
|
Nice work on this so far! |
vdamle
force-pushed
the
vd/h-l2-withdrawals-root
branch
from
1e8e5a2 to
82d0756
Compare
vdamle
changed the title
vdamle
requested review from
sebastianst,
axelKingsley,
ajsutton,
clabby and
maurelian
as code owners
vdamle
force-pushed
the
vd/h-l2-withdrawals-root
branch
from
dd44455 to
4dd7ad6
Compare
vdamle
changed the title
There was a problem hiding this comment.
Looks good generally. I've left a bunch of comments but primarily aimed at ensuring we're being really clear in the spec rather than disagreeing with the design (apart from the withdrawalRoot for genesis which seems weird to me but maybe I'm missing something).
vdamle
force-pushed
the
vd/h-l2-withdrawals-root
branch
from
84e0d42 to
e634c80
Compare
There was a problem hiding this comment.
This looks good to me, would like approval from @ajsutton or @protolambda before merge
There was a problem hiding this comment.
Looks good generally, just a couple of bits that I think could use more clarity. For the P2P stuff I don't have all the context so may just be misunderstanding things.
I am very strongly of the opinion that it's a mistake to have the genesis root hard code an empty hash for withdrawalsRoot instead of using the actual value from the account storage. The stateRoot field will be changing with any changes to the actual storage root anyway.
vdamle
force-pushed
the
vd/h-l2-withdrawals-root
branch
from
a76969a to
f19e845
Compare
Description
Spec Updates for Isthumus: L2 Withdrawals root spec updates
Tests
None
Metadata