Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Isthmus: operator fee #382
base: main
Are you sure you want to change the base?
Isthmus: operator fee #382
Changes from 59 commits
f4ef24d
d2f40a0
7ddbce3
2e12898
1407fa9
50c22ec
78cb4cb
6a78e21
fb53c85
b56048a
7c90f2b
f4e27b3
1526415
7085d98
148230b
fbf8dfb
48a25af
98fdb84
ead7704
1ade65a
4673839
b945faf
2f73dc2
43c5ea9
2efe231
816cc6c
a8e094e
1314351
63d1760
76fa61a
3afa960
f45744f
2a64355
2f0187f
1625dab
bc293f2
ff1aa7f
317ac76
bbb9e05
4c3eaca
cfdc6fc
3db2793
e2af323
b88dcf8
dcf4bdd
6ad2938
3d9f967
3c99591
2bf6246
4e0f724
9ab37f9
c7efd31
6c57838
1aa27f4
219e72c
762dbf7
99c9f4d
18c8127
54ea6a4
6512664
c7cffb1
0accd5f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw comment somewhere, maybe gone by now, that there would be restrictions on how large the operator fee scalar and fee constant should be set. If this feature becomes a standard chain features I think that this restriction is very important to protect user funds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that the operator fee will probably not become part of the superchain config since it adds complexity. Its purpose is more intended for non-standard chains, like op-succinct chains, for example.
My previous proposal wa the at the constant was between 0 and 600 Gwei and that the scalar was between 0 and 0.5x (basefee + priorityfee).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's the call signature for the function. Those 4 bytes are the first four bytes of
keccak("setL1BlockValuesIsthmus()")
. I'll clarify this in the spec.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bump on adding this to the spec to make it clear what this is