Skip to content

Commit

Permalink
replace TODO with comment about control flow
Browse files Browse the repository at this point in the history
  • Loading branch information
geoknee committed Apr 29, 2024
1 parent a06cdf2 commit f2530b5
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion packages/contracts-bedrock/src/L2/RevenueSharer.sol
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,9 @@ contract RevenueSharer is Initializable {
}
if (FeeVault(_feeVault).RECIPIENT() != address(this)) revert UnexpectedFeeVaultRecipient();
uint256 initial_balance = address(this).balance;
FeeVault(_feeVault).withdraw(); // TODO do we need a reentrancy guard around this?
// The following line will call back into the receive() function on this contract,
// causing all of the ether from the fee vault to move to this contract:
FeeVault(_feeVault).withdraw();
return address(this).balance - initial_balance;
}
}

0 comments on commit f2530b5

Please sign in to comment.