Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDNS updates v6 address #2012

Merged
merged 1 commit into from
Dec 22, 2024
Merged

DDNS updates v6 address #2012

merged 1 commit into from
Dec 22, 2024

Conversation

yorickdowne
Copy link
Contributor

@yorickdowne yorickdowne commented Dec 16, 2024

By duplicating the config. Tested on dual-stack and IPV4 only. On v4-only, the v6 probe fails and DDNS does not attempt to update the v6 address, as expected.

Addresses #1735 . Duplicating config is not clean, but appears to work with CloudFlare. This can be changed to "ipv4 and ipv6" if or when ddns-updater gains that functionality.

@pietjepuk2
Copy link
Contributor

LGTM

Copy link
Contributor

@pietjepuk2 pietjepuk2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also clear from your comment why you duplicated it 👍

@yorickdowne yorickdowne merged commit 51d999d into eth-educators:main Dec 22, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants