Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete migration to OWNERS file #733

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

jmhbnz
Copy link
Member

@jmhbnz jmhbnz commented Oct 18, 2023

As part of our setup for sig-etcd we intend to adopt the kubernetes project OWNERS file approach for managing repository and github org permissions automatically as code.

In #725 we introduced the OWNERS file for etcd website.

This pull request is a tidy-up to remove the old MAINTAINERS file approach.

Sub task under: etcd-io/etcd#16367

@jmhbnz jmhbnz changed the title Complete migration to owners file Complete migration to OWNERS file Oct 18, 2023
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thx @jmhbnz

@jberkus
Copy link
Contributor

jberkus commented Oct 19, 2023

So, somewhat ironically, I can't approve this because in the current in-between state my approval status is broken.

/lgtm nevertheless

@ahrtr
Copy link
Member

ahrtr commented Oct 19, 2023

So, somewhat ironically, I can't approve this because in the current in-between state my approval status is broken

Somehow you were not a maintainer in the team maintainers-website. Just changed your role to maintainer. Does it work now?

@jberkus
Copy link
Contributor

jberkus commented Oct 19, 2023

Yes, it works.

Approving the PR.

@jberkus jberkus merged commit 9bd1f15 into etcd-io:main Oct 19, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants