fix incorrect usage in readme #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lorain <[email protected]>
|
/cc @ahrtr PTAL, thanks! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, justlorain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
cc @pav-kv |
|
Hi, I noticed that this PR has been approved. Could someone please help merge it when convenient? Thanks! |
ahrtr
reviewed
Dec 12, 2024
README.md
Outdated
| // Note that they need to be started separately as well. | ||
| n := raft.StartNode(c, []raft.Peer{{ID: 0x02}, {ID: 0x03}}) | ||
| // Set peer list to all nodes in the cluster. | ||
| // Note that they need to be started separately. |
There was a problem hiding this comment.
Suggested change
| // Note that they need to be started separately. | |
| // Note that other nodes in the cluster, apart from this node, need to be started separately. |
Signed-off-by: Lorain <[email protected]>
justlorain
force-pushed
the
docs/fix_incorrect_usage
branch
from
8b680f6 to
8bd6d19
Compare
|
Please squash the commits, thx |
Let me squash it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
raft.StartNodemethod requires the full list of nodes in the cluster to establish the voters configuration.