raft: clean-up maybeSendAppend area #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a mechanical change, for code readability purposes. Signed-off-by: Pavel Kalinnikov <[email protected]>
Signed-off-by: Pavel Kalinnikov <[email protected]>
|
@ahrtr PTAL. This is a mechanical change, should be easy to review. See individual commits. |
ahrtr
reviewed
Jan 26, 2024
pav-kv
force-pushed
the
send-append-cleanup
branch
from
3171824 to
bf42310
Compare
erikgrinaker
approved these changes
Jan 30, 2024
|
Please resolve all review comments (or just mark it as resolved if you want to keep it as it's for now) before I merge this PR. thx |
The method will not be used in states other than StateProbe or StateReplicate, so there is little sense in having the error path in it. Signed-off-by: Pavel Kalinnikov <[email protected]>
Previously, maybeSendAppend would also try to fetch entries, only to return a few lines below at the errors check. Signed-off-by: Pavel Kalinnikov <[email protected]>
Signed-off-by: Pavel Kalinnikov <[email protected]>
pav-kv
force-pushed
the
send-append-cleanup
branch
from
bf42310 to
c55352f
Compare
|
@ahrtr Done. Can be merged, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a mechanical refactoring of
raft.maybeSendAppendmethod. A newmaybeSendSnapshotmethod is factored out for readability, and a couple of error conditions are optimized out. See individual commits.These are preparatory clean-ups for #130.