Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github workflow: enable workflow approval #117

Conversation

yashkundu
Copy link

Allow to run GitHub workflows for Pull Requests that have the ok-to-test label.

Fixes #116

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @yashkundu - Thanks for raising this.

Please ensure your commit is signed so the developer certificate of origin (DCO) check passes, i.e:

git rebase HEAD~1 --signoff
git push --force

Allow to run GitHub workflows for Pull Requests that have the ok-to-test
label.

Signed-off-by: Yashasvi Kundu <[email protected]>
@yashkundu yashkundu force-pushed the enable-github-workflow-approval-via-ok-to-test-label branch from 8e10fd0 to f0f4add Compare December 11, 2023 06:18
@yashkundu
Copy link
Author

@jmhbnz done

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @yashkundu! 🙏🏻

@jmhbnz jmhbnz requested a review from serathius December 12, 2023 08:16
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor comment.

.github/workflows/gh-workflow-approve.yaml Outdated Show resolved Hide resolved
@ahrtr ahrtr force-pushed the enable-github-workflow-approval-via-ok-to-test-label branch from 3d8cfd1 to 7e5fa79 Compare December 13, 2023 11:05
@ahrtr ahrtr merged commit 8757de3 into etcd-io:main Dec 13, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable GitHub workflows for PRs with the ok-to-test label
3 participants