replace t.error/fatal with assert/request (/tracker/inflights_test.go)

Signed-off-by: Xinyuan Du <[email protected]>

tracker/inflights_test.go

@@ -17,6 +17,7 @@ package tracker
 import (
 	"testing"
 
+	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 )
 
@@ -203,24 +204,18 @@ func TestInflightsFull(t *testing.T) {
 
 			addUntilFull := func(begin, end int) {
 				for i := begin; i < end; i++ {
-					if in.Full() {
-						t.Fatalf("full at %d, want %d", i, end)
-					}
+					require.False(t, in.Full(), "full at %d, want %d", i, end)
 					in.Add(uint64(i), uint64(100+i))
 				}
-				if !in.Full() {
-					t.Fatalf("not full at %d", end)
-				}
+				require.True(t, in.Full(), "not full at %d", end)
 			}
 
 			addUntilFull(0, tc.fullAt)
 			in.FreeLE(tc.freeLE)
 			addUntilFull(tc.fullAt, tc.againAt)
 
 			defer func() {
-				if r := recover(); r == nil {
-					t.Errorf("Add() did not panic")
-				}
+				assert.NotNil(t, recover(), "Add() did not panic")
 			}()
 			in.Add(100, 1024)
 		})