Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Go version to 1.22.10 #92

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

deanurag
Copy link
Contributor

@deanurag deanurag commented Dec 6, 2024

Updated the Go Version to 1.22.10 from 1.22.9.

Part of etcd-io/etcd#19000

@ivanvc
Copy link
Member

ivanvc commented Dec 6, 2024

Hi, @deanurag, thanks for your pull request. It seems like you didn't sign your commit. Could you please amend your commit and push it again? so the developer certificate of origin (DCO) check passes, i.e:

git commit --amend --signoff # Fix the signed off trailer
git push --force

Thanks!

@@ -2,7 +2,7 @@ module go.etcd.io/gofail/integration/sleep

go 1.22

toolchain go1.22.9
toolchain go1.22.10S
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a trailing "S" in this line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extemely sorry, for such mistake. I will do the required changes ASAP.

@deanurag deanurag force-pushed the update/go-version-to-1.22.10 branch from 173578d to 6df0c06 Compare December 6, 2024 07:22
@deanurag
Copy link
Contributor Author

deanurag commented Dec 6, 2024

@ivanvc Made the changes, please take a look.

@ivanvc
Copy link
Member

ivanvc commented Dec 6, 2024

@deanurag, can you please squash your commits into a single one? You can do this with:

git reset --soft HEAD^
git commit --amend --signoff -m "Update Go version from 1.22.9 to 1.22.10"
git push --force

Thanks :)

@deanurag deanurag force-pushed the update/go-version-to-1.22.10 branch from 6df0c06 to 54a650d Compare December 6, 2024 18:49
Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @deanurag.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, deanurag, ivanvc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ivanvc
Copy link
Member

ivanvc commented Dec 6, 2024

/ok-to-test

@ivanvc
Copy link
Member

ivanvc commented Dec 6, 2024

@ahrtr, I think this needs manual workflow approval.

@ahrtr ahrtr merged commit d16ce00 into etcd-io:master Dec 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants