-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Go version to 1.22.10 #92
Conversation
Hi, @deanurag, thanks for your pull request. It seems like you didn't sign your commit. Could you please amend your commit and push it again? so the developer certificate of origin (DCO) check passes, i.e:
Thanks! |
integration/sleep/go.mod
Outdated
@@ -2,7 +2,7 @@ module go.etcd.io/gofail/integration/sleep | |||
|
|||
go 1.22 | |||
|
|||
toolchain go1.22.9 | |||
toolchain go1.22.10S |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a trailing "S" in this line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extemely sorry, for such mistake. I will do the required changes ASAP.
173578d
to
6df0c06
Compare
@ivanvc Made the changes, please take a look. |
@deanurag, can you please squash your commits into a single one? You can do this with:
Thanks :) |
Signed-off-by: Anurag De <[email protected]>
6df0c06
to
54a650d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @deanurag.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, deanurag, ivanvc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
@ahrtr, I think this needs manual workflow approval. |
Updated the Go Version to 1.22.10 from 1.22.9.
Part of etcd-io/etcd#19000