Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump go toolchain to 1.23.3 #88

Closed
wants to merge 1 commit into from

Conversation

samuelbartels20
Copy link
Contributor

Please review

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: samuelbartels20
Once this PR has been reviewed and has the lgtm label, please assign spzala for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: samuelbartels20 <[email protected]>
@henrybear327
Copy link
Contributor

Hi @samuelbartels20,

Thanks for the PR!

But I believe we would only bump to 1.22.9 for the gofail repo. @ivanvc isn't it?

Reference: etcd-io/etcd#18847

@samuelbartels20
Copy link
Contributor Author

@henrybear327 On the tickets, i saw that it was asked to be bumped to 1.23.3
@ivanvc could you please confirm?

@ivanvc
Copy link
Member

ivanvc commented Nov 10, 2024

My bad, @henrybear327 is right. It should be 1.22.9

@samuelbartels20 samuelbartels20 deleted the go/1.23.3 branch November 10, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants