Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more info in the error message in downgrade detection #19081

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Dec 18, 2024

Add more info in the error message.

Also read #13405 (comment)

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.74%. Comparing base (0966b4d) to head (2830237).
Report is 8 commits behind head on main.

Additional details and impacted files
Files with missing lines Coverage Δ
server/storage/schema/schema.go 100.00% <100.00%> (ø)

... and 20 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19081      +/-   ##
==========================================
+ Coverage   68.71%   68.74%   +0.03%     
==========================================
  Files         420      420              
  Lines       35640    35641       +1     
==========================================
+ Hits        24489    24503      +14     
+ Misses       9723     9709      -14     
- Partials     1428     1429       +1     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0966b4d...2830237. Read the comment docs.

@ahrtr ahrtr force-pushed the log_migrage_20241218 branch from 5524ab7 to 2830237 Compare December 18, 2024 15:23
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@serathius
Copy link
Member

Right, maybe we could make it a warning as the procedure is repeating and inform user that it might happen and we will try again.

@ahrtr
Copy link
Member Author

ahrtr commented Dec 19, 2024

maybe we could make it a warning as the procedure

Makes sense to change this specific case as a warning. But there is a long call stack between generating the error/warning message and printing it as an error log. There are multiple reasons for the error log, we can't just change it as a warning log.

@ahrtr ahrtr merged commit 9db12c6 into etcd-io:main Dec 19, 2024
34 checks passed
@ahrtr ahrtr deleted the log_migrage_20241218 branch December 19, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants