Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more debug info when running into ErrSliceOutOfRange when reading WAL #19067

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Dec 16, 2024

Add more debug info when running into ErrSliceOutOfRange when reading WAL. If the gap between offset and len(ents) is huge, then most likely the WAL record is somehow corrupted, otherwise if it's just +-1, then most likely it's a bug (i.e of the raft).

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.74%. Comparing base (3241803) to head (9143bef).
Report is 4 commits behind head on main.

Additional details and impacted files
Files with missing lines Coverage Δ
server/storage/wal/wal.go 57.88% <100.00%> (+0.07%) ⬆️

... and 21 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19067      +/-   ##
==========================================
- Coverage   68.75%   68.74%   -0.02%     
==========================================
  Files         420      420              
  Lines       35626    35627       +1     
==========================================
- Hits        24495    24490       -5     
+ Misses       9712     9711       -1     
- Partials     1419     1426       +7     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3241803...9143bef. Read the comment docs.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 66b09ea into etcd-io:main Dec 16, 2024
35 checks passed
@ahrtr ahrtr deleted the wal_error_20241216 branch December 16, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants