-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use testify instead of t.Fatal or t.Error in pkg package (part 1) #18970
Conversation
Hi @mmorel-35. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
2678692
to
03192b6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 17 files with indirect coverage changes @@ Coverage Diff @@
## main #18970 +/- ##
==========================================
+ Coverage 68.77% 68.82% +0.04%
==========================================
Files 420 420
Lines 35623 35623
==========================================
+ Hits 24500 24516 +16
+ Misses 9699 9684 -15
+ Partials 1424 1423 -1 Continue to review full report in Codecov by Sentry.
|
03192b6
to
d623139
Compare
/ok-to-test |
/retest |
Signed-off-by: Matthieu MOREL <[email protected]>
d623139
to
0a71106
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks @mmorel-35
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, jmhbnz, mmorel-35 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
This uses testify instead of testing for t.Fatal or t.Error calls in pkg package
Related to #18972