Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.5] fix(defrag): handle errors during defrag #18842

Merged
merged 3 commits into from
Nov 6, 2024

Conversation

ghouscht
Copy link
Contributor

@ghouscht ghouscht commented Nov 6, 2024

@k8s-ci-robot
Copy link

Hi @ghouscht. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ghouscht ghouscht force-pushed the defrag-fixes-backport-3.5 branch from 733ff1f to f26ff91 Compare November 6, 2024 13:18
@ghouscht ghouscht marked this pull request as ready for review November 6, 2024 13:19
@ghouscht
Copy link
Contributor Author

ghouscht commented Nov 6, 2024

@ahrtr PR for the 3.5 backport. Should I squash the commits into one?

@ahrtr
Copy link
Member

ahrtr commented Nov 6, 2024

/ok-to-test

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ghouscht, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit ab8bfc2 into etcd-io:release-3.5 Nov 6, 2024
26 checks passed
@ghouscht ghouscht deleted the defrag-fixes-backport-3.5 branch November 6, 2024 15:04
@ivanvc
Copy link
Member

ivanvc commented Nov 6, 2024

Link to #18810

@ivanvc ivanvc mentioned this pull request Nov 7, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants