Fix robustness test logs by identifing failpoint availability on temporary cluster before creating subtest #18685
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 19 files with indirect coverage changes @@ Coverage Diff @@
## main #18685 +/- ##
==========================================
- Coverage 68.78% 68.76% -0.02%
==========================================
Files 420 420
Lines 35629 35629
==========================================
- Hits 24506 24500 -6
- Misses 9700 9702 +2
- Partials 1423 1427 +4 Continue to review full report in Codecov by Sentry.
|
| if err != nil { | ||
| t.Fatal(err) | ||
| } | ||
| err = forcestopCluster(c) |
There was a problem hiding this comment.
why not return the cluster and reuse it?
There was a problem hiding this comment.
Because logs will be directed to the different log name. During cluster creation we provide the logger, to correlate logs to tests, we use zaptest.New which takes the *testing.T as argument. If we reuse the cluster they will not be correlated to logs and clusters from all tests scenarios will be mixed.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fuweid, serathius, siyuanfoundation The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
serathius
force-pushed
the
robustness-failpoint-logs
branch
from
fee12d0 to
e8e388d
Compare
…orary cluster before creating subtest Signed-off-by: Marek Siarkowicz <[email protected]>
serathius
force-pushed
the
robustness-failpoint-logs
branch
from
e8e388d to
cd1aa92
Compare
|
@serathius: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
This fails in CI for some reason. Need to debug more. |
cc @ahrtr @fuweid @henrybear327 @siyuanfoundation @MadhavJivrajani