etcdserver: add auto compaction interval option

[jrcichra]

With enough key revisions per second, the constant 5 minute interval on revision compaction isn't fast enough to keep up with growth. Make the interval configurable, which will override the default behavior.

Also pass the configuration through to periodic compaction for finer control of when compaction happens based on time.

Fixes:
#18471

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jrcichra
Once this PR has been reviewed and has the lgtm label, please assign spzala for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @jrcichra. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[jrcichra]

My implementation here tries to support both periodic and revision but my original focus was solving the problem for just revision. It may not make as much sense for periodic.

[jmhbnz]

/ok-to-test

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 77.77778% with 6 lines in your changes missing coverage. Please review.

Project coverage is 68.80%. Comparing base (17fb752) to head (86ada85).
Report is 383 commits behind head on main.

❗ Current head 86ada85 differs from pull request most recent head f30e9dd

Please upload reports for the commit f30e9dd to get more accurate results.

Files with missing lines	Patch %	Lines
server/etcdserver/api/v3compactor/revision.go	50.00%	2 Missing and 1 partial ⚠️
server/embed/etcd.go	75.00%	1 Missing and 1 partial ⚠️
server/etcdserver/api/v3compactor/compactor.go	50.00%	1 Missing ⚠️

Additional details and impacted files

Files with missing lines	Coverage Δ
server/config/config.go	79.76% <ø> (ø)
server/embed/config.go	79.52% <100.00%> (+0.03%)	⬆️
server/etcdserver/api/v3compactor/periodic.go	90.58% <100.00%> (+0.34%)	⬆️
server/etcdserver/server.go	81.58% <100.00%> (ø)
server/etcdserver/api/v3compactor/compactor.go	40.00% <50.00%> (ø)
server/embed/etcd.go	75.76% <75.00%> (-0.02%)	⬇️
server/etcdserver/api/v3compactor/revision.go	77.04% <50.00%> (-2.27%)	⬇️

... and 17 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18472      +/-   ##
==========================================
- Coverage   68.84%   68.80%   -0.05%     
==========================================
  Files         420      420              
  Lines       35540    35555      +15     
==========================================
- Hits        24466    24462       -4     
- Misses       9651     9665      +14     
- Partials     1423     1428       +5     

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17fb752...f30e9dd. Read the comment docs.

[jrcichra]

/retest

[jrcichra]

I'm passing all the tests now. @jmhbnz how should I proceed? I see there's a codecov report but there's a large section of code I didn't touch regarding failed auto compaction.

[moficodes]

/assign

[jrcichra]

@moficodes Thanks for assigning! Let me know of any changes I should make.

[jrcichra]

Rebase is complete 🎉

[jrcichra]

Hey @moficodes have you had a chance to look at this change?

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.