Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release.md to reflect notes taken during 3.5.15 release #18383

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

wenjiaswe
Copy link
Contributor

@@ -62,6 +62,7 @@ which don't need to be executed before releasing each version.
4. Authenticate the image registry, refer to [Authentication methods](https://cloud.google.com/container-registry/docs/advanced-authentication).
- `gcloud auth login`
- `gcloud auth configure-docker`
5. Ensure there is at least 500MB of free space on your Linux machine.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please follow #18346 (comment)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, did that one wrong... Thanks! Updated.

@ahrtr
Copy link
Member

ahrtr commented Aug 1, 2024

Please try not to create branch on the etcd-io/etcd directly (e.g. wenjiaswe-patch-1 in this PR). Instead, please fork the repo, and create branch on your forked repo.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, serathius, wenjiaswe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ahrtr,serathius,wenjiaswe]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit ca2d91c into main Aug 1, 2024
69 checks passed
@ivanvc
Copy link
Member

ivanvc commented Aug 4, 2024

Please try not to create branch on the etcd-io/etcd directly (e.g. wenjiaswe-patch-1 in this PR). Instead, please fork the repo, and create branch on your forked repo.

Maybe it is a good time to clean up branches wenjiaswe-patch-1 and ptabor-patch-1?

@jmhbnz jmhbnz deleted the wenjiaswe-patch-1 branch August 4, 2024 06:57
@jmhbnz
Copy link
Member

jmhbnz commented Aug 4, 2024

Maybe it is a good time to clean up branches wenjiaswe-patch-1 and ptabor-patch-1?

Done - good to clean up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

6 participants