-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.5] Fix govulncheck CI check #18170
Merged
ahrtr
merged 3 commits into
etcd-io:release-3.5
from
henrybear327:ci/fix_govulncheck_release_3.5
Jun 14, 2024
Merged
[3.5] Fix govulncheck CI check #18170
ahrtr
merged 3 commits into
etcd-io:release-3.5
from
henrybear327:ci/fix_govulncheck_release_3.5
Jun 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/cc @ivanvc @ahrtr @serathius |
Follow up on #17703 |
henrybear327
force-pushed
the
ci/fix_govulncheck_release_3.5
branch
2 times, most recently
from
June 13, 2024 20:28
1ca4d4b
to
9952090
Compare
4 tasks
ivanvc
reviewed
Jun 13, 2024
henrybear327
force-pushed
the
ci/fix_govulncheck_release_3.5
branch
2 times, most recently
from
June 14, 2024 09:31
d5d3645
to
644b234
Compare
This commit fixed the Go Vulnerability Checker CI job, which isn't scanning for all go.mod files within the project. Reference: - etcd-io#18168 Signed-off-by: Chun-Hung Tseng <[email protected]>
Extracted log from govulncheck, suggesting that we should bump the version of golang.org/x/net === Symbol Results === Vulnerability #1: GO-2024-2687 HTTP/2 CONTINUATION flood in net/http More info: https://pkg.go.dev/vuln/GO-2024-2687 Module: golang.org/x/net Found in: golang.org/x/[email protected] Fixed in: golang.org/x/[email protected] Reference: - etcd-io#17708 Signed-off-by: Chun-Hung Tseng <[email protected]>
…ab57 to v0.0.0-20220412211240-33da011f77ad Extracted log from govulncheck, suggesting that we should bump the version of golang.org/x/sys Vulnerability #1: GO-2022-0493 Incorrect privilege reporting in syscall and golang.org/x/sys/unix More info: https://pkg.go.dev/vuln/GO-2022-0493 Module: golang.org/x/sys Found in: golang.org/x/[email protected] Fixed in: golang.org/x/[email protected] Signed-off-by: Chun-Hung Tseng <[email protected]>
henrybear327
force-pushed
the
ci/fix_govulncheck_release_3.5
branch
from
June 14, 2024 09:33
644b234
to
e72a799
Compare
ahrtr
approved these changes
Jun 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please also update 3.5 changelog
ivanvc
approved these changes
Jun 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @henrybear327
henrybear327
added a commit
to henrybear327/etcd
that referenced
this pull request
Jun 14, 2024
Fully address CVE-2023-45288 and fix govulncheck CI check Reference: - etcd-io#18170 Signed-off-by: Chun-Hung Tseng <[email protected]>
/retitle [3.5] Fix govulncheck CI check |
k8s-ci-robot
changed the title
Fix govulncheck CI check on release-3.5
[3.5] Fix govulncheck CI check
Jun 28, 2024
aneesh1
pushed a commit
to DataDog/etcd
that referenced
this pull request
Sep 24, 2024
…_release_3.5 Fix govulncheck CI check on release-3.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixed the Go Vulnerability Checker CI job, which isn't scanning for all go.mod files within the project.
Reference:
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.