Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changelog: add 3.4 and 3.5 note about go 1.21.10 #18019

Merged

Conversation

lavishpal
Copy link
Contributor

Updates 3.4 and 3.5 CHANGELOGs to add a line that the binaries are compiled with go version 1.21.10
Related to #17964

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

@k8s-ci-robot
Copy link

Hi @lavishpal. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ivanvc
Copy link
Member

ivanvc commented May 16, 2024

/ok-to-test

@ivanvc
Copy link
Member

ivanvc commented May 16, 2024

Thanks, @lavishpal. Question for @jmhbnz or @ahrtr: do we want to specify that we bumped Go to address CVE-2024-24787? I can't find any previous references to Go version bumps that mentioned CVEs.

@ahrtr
Copy link
Member

ahrtr commented May 16, 2024

do we want to specify that we bumped Go to address CVE-2024-24787?

I think it's nice to have.

@ivanvc
Copy link
Member

ivanvc commented May 16, 2024

/retest

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's nice to have, then this should be good enough to merge. Thanks, @lavishpal.

@ahrtr ahrtr merged commit 97a9af9 into etcd-io:main May 17, 2024
45 checks passed
@lavishpal lavishpal deleted the changelog/add-3.4-and-3.5-note-about-go-1.21.10 branch May 17, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants