Fix caching by not depending on PHONY target in non-PHONY target

[serathius]

cc @MadhavJivrajani @fuweid @siyuanfoundation

[jmhbnz]

Do we have an issue for this or some more context on what is happening with cache?

[serathius]

If you run make test-robustness-issue14370 twice, it will download and build etcd-v3.5.4 twice, when it doesn't need to.

[ivanvc]

Would it make sense to define the install-gofail phony target as dependent on the actual gofail binary path? This would work, too, without having to change the target dependencies. i.e., something like:

@@ -58,13 +56,14 @@ gofail-disable:
        cd ./tests && go mod tidy
 
 .PHONY: install-gofail
-install-gofail:
+install-gofail: $(GOPATH)/bin/gofail
+
+$(GOPATH)/bin/gofail:
        go install go.etcd.io/gofail@${GOFAIL_VERSION}

[serathius]

Would it make sense to define the install-gofail phony target as dependent on the actual gofail binary path? This would work, too, without having to change the target dependencies. i.e., something like:

@@ -58,13 +56,14 @@ gofail-disable:
        cd ./tests && go mod tidy
 
 .PHONY: install-gofail
-install-gofail:
+install-gofail: $(GOPATH)/bin/gofail
+
+$(GOPATH)/bin/gofail:
        go install go.etcd.io/gofail@${GOFAIL_VERSION}

Right, but what happens when GOFAIL_VERSION is changed?

[ivanvc]

Right, but what happens when GOFAIL_VERSION is changed?

Good point, it won't work. Although we could add the version to the path, it won't be a clean solution.

[serathius]

Figured out we can do it by depending on go.mod, PTAL @ivanvc

[ivanvc]

/lgtm 👍

[fuweid]

LGTM

We need to bump go version first to make CI happy

[ivanvc]

We need to bump go version first to make CI happy

@fuweid, we're tracking that in #17964.

[serathius]

LGTM

We need to bump go version first to make CI happy

Or I can just merge :P