Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Migrate member tests to common framework #14271

Closed
wants to merge 0 commits into from

Conversation

clement2026
Copy link
Contributor

@clement2026 clement2026 commented Jul 25, 2022

Context #13637

Comment on lines 45 to 47
if gotNum == 0 {
t.Fatalf("number of members is 0")
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check is not needed as you check expectNum != gotNum above. expectNum is guaranteed to be at least 1.

@serathius
Copy link
Member

Please fix DCO by running git commit --amend -s

@clement2026
Copy link
Contributor Author

Please fix DCO by running git commit --amend -s

Thanks!

@codecov-commenter
Copy link

Codecov Report

Merging #14271 (50ba143) into main (4977877) will decrease coverage by 0.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #14271      +/-   ##
==========================================
- Coverage   75.40%   75.23%   -0.17%     
==========================================
  Files         456      456              
  Lines       36919    36919              
==========================================
- Hits        27838    27776      -62     
- Misses       7345     7397      +52     
- Partials     1736     1746      +10     
Flag Coverage Δ
all 75.23% <ø> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/pkg/v3/tlsutil/tlsutil.go 83.33% <0.00%> (-8.34%) ⬇️
client/v3/namespace/watch.go 87.87% <0.00%> (-6.07%) ⬇️
server/etcdserver/api/v3rpc/watch.go 83.55% <0.00%> (-5.04%) ⬇️
client/v3/leasing/cache.go 87.77% <0.00%> (-3.89%) ⬇️
server/etcdserver/cluster_util.go 70.35% <0.00%> (-3.17%) ⬇️
client/v3/concurrency/election.go 79.68% <0.00%> (-2.35%) ⬇️
server/etcdserver/api/rafthttp/msgappv2_codec.go 69.56% <0.00%> (-1.74%) ⬇️
server/storage/mvcc/watchable_store.go 88.40% <0.00%> (-1.45%) ⬇️
server/etcdserver/api/v3rpc/maintenance.go 75.34% <0.00%> (-1.37%) ⬇️
pkg/schedule/schedule.go 80.45% <0.00%> (-1.15%) ⬇️
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

@clement2026 clement2026 changed the title tests: Migrate member list tests to common framework tests: Migrate member tests to common framework Jul 26, 2022
@clement2026 clement2026 marked this pull request as ready for review July 26, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants