Skip to content

Commit

Permalink
Merge pull request #18400 from thedtripp/backportOwnersFile
Browse files Browse the repository at this point in the history
Complete backport of migration to OWNERS file.
  • Loading branch information
jmhbnz authored Aug 4, 2024
2 parents c354040 + 49d9234 commit fd14c92
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 28 deletions.
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ This is a rough outline of what a contributor's workflow looks like:
- Make sure commit messages are in the proper format (see below).
- Push changes in a topic branch to a personal fork of the repository.
- Submit a pull request to etcd-io/etcd.
- The PR must receive a LGTM from two maintainers found in the MAINTAINERS file.
- The PR must receive a LGTM from two maintainers found in the OWNERS file.

Thanks for contributing!

Expand Down
6 changes: 3 additions & 3 deletions GOVERNANCE.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ please see [CONTRIBUTING](./CONTRIBUTING.md) guide.

## Maintainers

[Maintainers](./MAINTAINERS) are first and foremost contributors that have shown they
[Maintainers](./OWNERS) are first and foremost contributors that have shown they
are committed to the long term success of a project. Maintainership is about building
trust with the current maintainers of the project and being a person that they can
depend on to make decisions in the best interest of the project in a consistent manner.
Expand Down Expand Up @@ -48,12 +48,12 @@ of the maintainers and moved to emeritus status.
Life priorities, interests, and passions can change. If a maintainer needs to step
down, inform other maintainers about this intention, and if possible, help find someone
to pick up the related work. At the very least, ensure the related work can be continued.
Afterward, create a pull request to remove yourself from the [MAINTAINERS](./MAINTAINERS)
Afterward, create a pull request to remove yourself from the [MAINTAINERS](./OWNERS)
file.

## Reviewers

[Reviewers](./MAINTAINERS) are contributors who have demonstrated greater skill in
[Reviewers](./OWNERS) are contributors who have demonstrated greater skill in
reviewing the code contribution from other contributors. Their LGTM counts towards
merging a code change into the project. A reviewer is generally on the ladder towards
maintainership. New reviewers must be nominated by an existing maintainer and must be
Expand Down
24 changes: 0 additions & 24 deletions MAINTAINERS

This file was deleted.

0 comments on commit fd14c92

Please sign in to comment.