Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to go 1.23 #8

Merged
merged 3 commits into from
Dec 6, 2024
Merged

Update to go 1.23 #8

merged 3 commits into from
Dec 6, 2024

Conversation

jmhbnz
Copy link
Member

@jmhbnz jmhbnz commented Dec 4, 2024

Let's try and keep the operator aligned with our other etcd-io projects.

  • Use go version from go.mod in actions workflows.
  • Update to go 1.23.
  • Align devcontainer with etcd-io/etcd.

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @jmhbnz

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, jmhbnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ivanvc
Copy link
Member

ivanvc commented Dec 5, 2024

Link to etcd-io/etcd#19000.

@ahrtr ahrtr merged commit 340fe74 into etcd-io:main Dec 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants