dependency : update go version to 1.22.3 #753
Conversation
CHANGELOG/CHANGELOG-1.4.md
Outdated
| @@ -26,7 +26,7 @@ | |||
| - [Enhance robustness test to cover XFS](https://github.com/etcd-io/bbolt/pull/707) | |||
|
|
|||
| ### Other | |||
| - [Bump go toolchain version to 1.22.2](https://github.com/etcd-io/bbolt/pull/712) | |||
| - [Bump go toolchain version to 1.22.3](https://github.com/etcd-io/bbolt/pull/712) | |||
There was a problem hiding this comment.
v1.4.0-alpha.1 has already been released. Please revert this change, and I will take care of it later. Thanks
There was a problem hiding this comment.
LGTM, but I think we want to squash the commits before merging. Thanks @lavishpal.
lavishpal
force-pushed
the
update/go-version-to-1.22.3
branch
from
63c139e to
37b2daa
Compare
Done |
lavishpal
force-pushed
the
update/go-version-to-1.22.3
branch
3 times, most recently
from
cbe5f53 to
e38c515
Compare
.github/workflows/tests-template.yml
Outdated
| @@ -16,7 +16,7 @@ permissions: read-all | |||
| jobs: | |||
| test-linux: | |||
| # this is to prevent arm64 jobs from running at forked projects | |||
| if: ${{ github.repository == 'etcd-io/bbolt' || inputs.runs-on == 'ubuntu-latest' }} | |||
| if: ${{ github.repository == 'etcd-io/bbolt' || startsWith(inputs.runs-on, 'ubuntu') }} | |||
There was a problem hiding this comment.
why you change this?
Sorry i didn't understand or misread your previous comment.
There was a problem hiding this comment.
It seems like you wrongly rebased/squashed your commits. This commit is reverting 2064324
There was a problem hiding this comment.
Could you please guide me that how can I solve this?
There was a problem hiding this comment.
One way of solving this would be first to ensure that your branch is up to date:
git fetch origin
git rebase origin/main
Then, you could checkout the test-template.yml file from main, and amend your commit:
git checkout origin/main -- .github/workflows/tests-template.yml
git commit --amend
(Then, of course, push with -f to your branch).
There was a problem hiding this comment.
Done all the steps as you said.
|
/ok-to-test |
Signed-off-by: Lavish pal <[email protected]>
lavishpal
force-pushed
the
update/go-version-to-1.22.3
branch
from
e38c515 to
6a04aaa
Compare
Upgrade go version to 1.22.3
Part of etcd-io/etcd#17964