Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eslint/Rollup #110

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Eslint/Rollup #110

wants to merge 8 commits into from

Conversation

brettz9
Copy link

@brettz9 brettz9 commented Apr 29, 2020

Builds on #109.

  • Breaking change: Adds exports
  • Enhancement: Provide ESM distribution pointed to by exports
  • Refactoring: Use ES6 classes
  • Refactoring: Move let closer to scope of use (or convert to const); prefer for-of
  • Refactoring: Switch to native Node ESM source, using Rollup + Babel/Terser
  • Refactoring: Further ES6 class
  • Linting: Switch from JSHint to ESLint

@brettz9
Copy link
Author

brettz9 commented Apr 29, 2020

@michaelficarra : If you are able to review, the ones here on estraverse would probably be helpful to have done first so I can simplify the Rollup routine on its dependees (to avoid need for the CJS plugin)

Update: Probably should resolve concerns at estools/esutils#34 first actually

@sanex3339
Copy link
Contributor

HI. Can you please duplicate this PR to my fork?
https://github.com/javascript-obfuscator/estraverse

brettz9 added 7 commits March 10, 2022 17:44
- npm: Add recommended `bugs`, `keywords`, `dependencies` and use `author`/`contributors`
- npm: Update devDeps, and switch to Babel 7/preset-env
- npm: Use simple run script syntax
- npm: Drop `package-lock.json` in favor of npmrc for consistency with other estools projects
- Maintenance: Add `.editorconfig`
- Maintenance: Drop use of gulpfile
- Update: Mocha API
- Testing: Add nyc
- Testing: Use `chai/register-expect`
- Testing: Drop bundled `esprima` in favor of using versioned
- Testing: Update espree API to supply `sourceType`/`ecmaVersion`
- Testing: Enable `espree` for dynamic import and adjust test expectation to take into account full Program context
- Docs: Use more modern syntax in examples
…t`); prefer for-of

- Refactoring: Use ES6 classes
- Refactoring: Switch to ESM source, using Rollup + Babel/Terser
- Refactoring: Further ES6 class
@brettz9
Copy link
Author

brettz9 commented Mar 13, 2022

I've added native Node ESM support.

@sanex3339 : I'm planning on maintaining my own fork (already started at @es-joy/estraverse) if I don't hear back here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants