Multi plug improvements (CON-1465) #1202
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
hankedan000
force-pushed
the
multi-plug-improvements
branch
from
b1859f4 to
dae802f
Compare
github-actions
bot
changed the title
Glad to hear that this example was helpful in curating your solution. |
shubhamdp
reviewed
Dec 11, 2024
shubhamdp
reviewed
Dec 24, 2024
|
@hankedan000 Added minor comments, change LGTM! Also, please resolve the addressed comments. |
shubhamdp
approved these changes
Dec 31, 2024
|
LGTM! |
shripad621git
approved these changes
Dec 31, 2024
* adds reset button logic * adds support for upt to 16 plugs Add ability to configure up to 16 plugs Add factory reset via GPIO Use bsp instead of device_hal for button initialization Check if reset button IO pin # conflicts with plugs Update default IO to be usable accross all supported targets Updates readme Adds reset_gpio out arg. Fixed error code usage. Fixed non-static variable names
hankedan000
force-pushed
the
multi-plug-improvements
branch
from
575d4fc to
a41e41b
Compare
pimpalemahesh
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to make a multi-zone light controlled, and this multi-on-off-plugin example was really close to what I wanted. I just wanted to control more lights really. This updates makes this example project more of an "out of the box" solution for my project, and I hope others will find the same.
default options
full options