Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Article: Added WLED article for the powered by community series #349

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

pedrominatel
Copy link
Member

@pedrominatel pedrominatel commented Dec 3, 2024

Description

This PR adds a new article about the WLED community project. This is the first article of a new series of community articles with ESP32s.

The article describes what it is and the first steps on how to get started.

@Aircoookie It would be great if you could give your opinion about this article. Thank you very much!

Related

Testing


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Git history is clean — commits are squashed to the minimum necessary.

@pedrominatel
Copy link
Member Author

Any comment, @Aircoookie?

Copy link

@Aircoookie Aircoookie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads great, thank you so much!


Making amazing lighting installations could sound very complex, requiring a lot of expensive hardware and software, however, thanks to the community and some ESP32 or ESP8266, this is not that complex and you can do it yourself.

Today we will talk about a community project, created by [Christian Schwinne a.k.a Aircoookie](https://github.com/Aircoookie), called [WELD](https://kno.wled.ge/).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a small typo here [WELD]

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your review! Fixed!

@pedrominatel pedrominatel force-pushed the wled-project-from-community branch from b380a12 to 0f99737 Compare December 30, 2024 15:44
Copy link
Collaborator

@f-hollow f-hollow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pedrominatel A few nitpicks and small suggestions to improve the reader's experience.


### Hardware

If you want to test the WLED with one of Espressif boards, try with the [ESP32-C3-Lyra V2.0](https://docs.espressif.com/projects/esp-adf/en/latest/design-guide/dev-boards/user-guide-esp32-c3-lyra.html). The ESP32-C3-Lyra supports the addressable and RGB LED strips.
Copy link
Collaborator

@f-hollow f-hollow Jan 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closer to the beginning of the article, you say that several Espressif SoCs are supported. My immediate assumption would be that all development boards based on those SoCs should be supported. Now you single out one specific board and recommend it. Why? Suggest that you explain it here.

If this board is so good, why not mention it in How to use together with the supported SoCs?

Update:

I reached the citation under the overview of components and now I see why you recommend this board. Suggest placing this information above the pictures and maybe even move the whole thing closer to the beginning.

If you choose to move it closer to the beginning, consider creating a separate section Hardware and mention supported SoCs and this board.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll make it clear why I'm recommending this board.
This board was created to control addressable and regular RGB LEDs with a 12V power input (LED strips can usually be 5V or 12V).


### Hardware

If you want to test the WLED with one of Espressif boards, try with the [ESP32-C3-Lyra V2.0](https://docs.espressif.com/projects/esp-adf/en/latest/design-guide/dev-boards/user-guide-esp32-c3-lyra.html). The ESP32-C3-Lyra supports the addressable and RGB LED strips.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For lack of experience with LEDs, I assume that addressable and RGB are two independent characteristics of LEDs.

Regarding addressable, you already mentioned earlier that non-adressable are not supported. This characteristic is covered.

However, regarding RGB it is not clear. Earlier you said that RGBW are supported. Now you mention RGB LED strips are supported. Maybe you can elaborate on that and say what other types exist and what is supported/unsupported.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The WLED project only supports addressable LEDs, however, the board supports regular RGB LEDs (one GPIO per color). The addressable LEDs require just one GPIO and use a protocol to define the color of each segment.
I'll propose changes to explain this in a better way.

Copy link

github-actions bot commented Jan 3, 2025

🎉 A preview for this PR is available at: https://preview-developer.espressif.com/pr349/

@pedrominatel
Copy link
Member Author

Thanks @f-hollow for your review. I've implemented the requested changes and added more details about the board.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants