Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick doc and script fixes + missing folder #2

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

rswezey
Copy link

@rswezey rswezey commented Jun 7, 2019

  • The specified TF version can't seem to be installed with Python 3.7, but everything works in 3.6
  • Sorting model parameters explanation fix
  • Variable fix in run_median.py
  • elif fix in run_sort.py

Additionally, the dataset loader seems absent for the PyTorch code (I tried to use the one from the Flow-GAN repo but the code is different):

(neuralsort) root@85d56302ced7:/notebooks/neuralsort# cd pytorch
(neuralsort) root@85d56302ced7:/notebooks/neuralsort/pytorch# python run_dknn.py --k=9 --tau=64 --nloglr=3 --method=deterministic --dataset=cifar10 -startnew
setGPU: Setting GPU to: 0
Traceback (most recent call last):
  File "run_dknn.py", line 14, in <module>
    from dataset import DataSplit
ModuleNotFoundError: No module named 'dataset'

@rswezey rswezey requested a review from tloen June 24, 2019 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant