Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add typescript support #103

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Skona27
Copy link

@Skona27 Skona27 commented Dec 10, 2019

Changes:

  • added typescript declaration file containting typings Slider component
  • change in webpack build process - added copy-webpack-plugin in order to copy declaration files to build directory,
  • bumped library version to 2.1.0

I recommend using Prettier for this project. I had difficulties to format webpack.config.js file, didn't know if I should use tabs with width 8 or 7 or 6. I decided to format this with my default settings. Please tell me how I can correct this.

@Skona27 Skona27 mentioned this pull request Dec 10, 2019
@erichbehrens
Copy link
Owner

Thank you @Skona27 !

The project is configured to use eslint. AFAIK prettier should be able to pick up eslint settings, but I have to admit I stopped using it because of some issues with that and eslint/tslint alone work much better in my case.

Currently the indentation is set to tabs. I'd ask you to push again with tabs, so it is clear what has changed in the config file for this PR. I have already compared it ignoring whitespace and it looks good. I'll later change this setting to spaces as it seems to be far more common.

@Skona27
Copy link
Author

Skona27 commented Dec 12, 2019

Hi!
I've indented webpack.config.js with tabs, so now it should be clear what have changed.

@Skona27
Copy link
Author

Skona27 commented Jan 8, 2020

@erichbehrens Any updates on the subject?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants